Fix locked key missing password message #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pattern for matching when a password is not provided for a locked key
prd-fox
requested review from
chris-j-h,
melowe,
namtruong,
nicolae-leonte-go and
SatpalSandhu61
as code owners
prd-fox
changed the title
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
============================================
- Coverage 99.43% 99.43% -0.01%
+ Complexity 1643 1636 -7
============================================
Files 256 254 -2
Lines 4991 4979 -12
Branches 247 245 -2
============================================
- Hits 4963 4951 -12
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
melowe
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this also eagerly loads filesystem key files, and discards any errors that occurred. The thought process is that these errors will get picked up during validation of the config object.
Fixes #541